[ovs-dev] [PATCH] netdev-dpdk: Refactor dpdk_class_init()

Daniele Di Proietto ddiproietto at vmware.com
Thu Jul 17 18:29:10 UTC 2014


Thanks,

Daniele

On Jul 17, 2014, at 11:20 AM, Pravin Shelar <pshelar at nicira.com> wrote:

> On Wed, Jul 16, 2014 at 5:10 PM, Daniele Di Proietto
> <ddiproietto at vmware.com> wrote:
>> The following changes were made:
>> 
>> - Since we have two dpdk classes, we should split the initial operations needed
>>  by both classes from the initialization needed by each class.
>> - The dpdk_ring class does not need an initialization function: it has been
>>  removed. This also prevents many testcase from failing, because
>>  dpdk_ring_class_init() was printing an unexpected log message
>>  (OVS_VSWITCHD_START at tests/ofproto-macros.at:54 check for a specific set of
>>  startup log messages)
>> - If the user doesn't pass the --dpdk option we do not register the dpdk*
>>  classes
>> - Do not call VLOG_ERR if there are 0 dpdk ethernet device. OVS can now be used
>>  with dpdk_ring devices.
>> 
>> Signed-off-by: Daniele Di Proietto <ddiproietto at vmware.com>
> 
> I moved common init at beginning  and pushed the patch.
> 
> Thanks,
> Pravin




More information about the dev mailing list