[ovs-dev] [PATCH 3/4] dpif-windows: Implement datapath interface for windows.

Ben Pfaff blp at nicira.com
Mon Jul 21 20:59:15 UTC 2014


On Fri, Jul 18, 2014 at 5:27 PM, Saurabh Shah <ssaurabh at vmware.com> wrote:
> Ben Pfaff writes:
> > The logging in dpif_windows_flow_del() seems like a debugging stray.
>
> Do you mean in do_put?

I mean the one here:

+static int
+dpif_windows_flow_del(struct dpif *dpif, const struct dpif_flow_del *del)
+{
+    VLOG_INFO("dpif_windows_flow_del\n");
+    return do_put(dpif, OVSWIN_FLOW_PUT_DELETE, del->key, del->key_len,
+                  NULL, 0, del->stats);
+}

> > The quoted string here appears to have two \\ escapes followed by a
> > \. escape.  Does \. mean something special in Windows?
> > #define OVS_DEVICE_PATH    TEXT("\\\\\.\\OvsIoctl")
>
> Yes, to specify the device namespace instead of the file namespace.
> http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx

OK, that page talks about a special file name convention \\.\.  When
we double each of the backslashes for a C string we get four slashes
at the beginning: \\\\.  But your code has five, so there's one backslash
modifying a period ("\.").  Do you need to change the five backslashes
to four?

> I succumbed to "review fatigue" looking at the netdev code, so no
> comments on that yet.  Tomorrow, I'll try to continue my look through,
> and then I'll shift over to looking at the cloudbase implementation.

I guess I forgot to continue reading.  I'll wait for the next posting to
continue.



More information about the dev mailing list