[ovs-dev] [PATCH] debian: Avoid -Wformat-zero-length warnings.

Ben Pfaff blp at nicira.com
Tue Jul 22 23:01:10 UTC 2014


Thanks, applied to master.

On Tue, Jul 22, 2014 at 03:54:47PM -0700, Justin Pettit wrote:
> Acked-by: Justin Pettit <jpettit at nicira.com>
> 
> 
> On Tue, Jul 22, 2014 at 11:50 AM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > Debian puts an extra "-Wformat" in the CFLAGS following OVS's own
> > "-Wformat -Wno-format-zero-length", which therefore overrides
> > -Wno-format-zero-length, so this commit adds an extra
> > -Wno-format-zero-length to avoid those false positives.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> >  debian/rules |    7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/debian/rules b/debian/rules
> > index 5cf9f02..081f24a 100755
> > --- a/debian/rules
> > +++ b/debian/rules
> > @@ -35,6 +35,13 @@ endif
> >  buildflags := $(shell if dpkg-buildflags --export=configure >/dev/null
> > 2>&1; \
> >                       then dpkg-buildflags --export=configure; fi)
> >
> > +# dpkg-buildflags tends to turn on -Wformat, which is admirable, but
> > +# the -Wformat-zero-length subset of that option triggers a couple of
> > +# false positives in Open vSwitch so turn it right back off again.
> > +# (We do this in configure.ac also, but the Debian buildflags override
> > +# those.)
> > +buildflags := $(patsubst -Wformat,-Wformat
> > -Wno-format-zero-length,$(buildflags))
> > +
> >  configure: configure-stamp
> >  configure-stamp:
> >         dh_testdir
> > --
> > 1.7.10.4
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >



More information about the dev mailing list