[ovs-dev] [PATCH] ofproto-dpif-upcall: Fix sparse warnings.
Ben Pfaff
blp at nicira.com
Sat Jul 26 19:19:03 UTC 2014
Fixes these warnings from "sparse":
../ofproto/ofproto-dpif-upcall.c:761:1: warning: symbol 'free_upcall' was
not declared. Should it be static?
../ofproto/ofproto-dpif-upcall.c:849:1: warning: symbol 'convert_upcall'
was not declared. Should it be static?
Signed-off-by: Ben Pfaff <blp at nicira.com>
---
ofproto/ofproto-dpif-upcall.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index f00c17f..654fbd3 100644
--- a/ofproto/ofproto-dpif-upcall.c
+++ b/ofproto/ofproto-dpif-upcall.c
@@ -757,7 +757,7 @@ upcall_init(struct upcall *upcall, struct flow *flow, struct ofpbuf *packet,
xlate_actions(&xin, &upcall->xout);
}
-void
+static void
free_upcall(struct upcall *upcall)
{
xlate_out_uninit(&upcall->xout);
@@ -845,7 +845,7 @@ read_upcalls(struct handler *handler,
return n_upcalls;
}
-int
+static int
convert_upcall(struct udpif *udpif, struct upcall *upcall)
{
struct dpif_upcall *dupcall = &upcall->dpif_upcall;
--
1.9.1
More information about the dev
mailing list