[ovs-dev] [PATCH] match: Fix match_set_vlan_vid when vid is OFPVID12_NONE

[Ben Pfaff]

On Sun, Jul 27, 2014 at 01:11:19PM +0800, Kmindg wrote:
> When vid is OFPVID12_NONE, we should match only packets without vlan
> tag. Before this commit we set vlan_tci to 0x0000/0x1fff which is fine
> because it's only match packets without vlan tag too. But if we add flow
> using:
>     ovs-ofctl -O OpenFlow10 add-flow br0 dl_vlan=0xffff,actions=drop
>     ovs-ofctl -O OpenFlow13 add-flow br0 dl_vlan=0xffff,actions=drop
> , we get two flows:
>     ovs-ofctl -O OpenFlow10 dump-flows br0
>     cookie=0x0, duration=88.227s, table=0, n_packets=0, n_bytes=0,
>     idle_age=88, vlan_tci=0x0000 actions=drop
>     cookie=0x0, duration=67.503s, table=0, n_packets=0, n_bytes=0,
>     idle_age=67, vlan_tci=0x0000/0x1fff actions=drop
> 
>     ovs-ofctl -O OpenFlow13 dump-flows br0
>     cookie=0x0, duration=36.657s, table=0, n_packets=0, n_bytes=0,
>     vlan_tci=0x0000/0x1fff actions=drop
>     cookie=0x0, duration=15.933s, table=0, n_packets=0, n_bytes=0,
>     vlan_tci=0x0000/0x1fff actions=drop

Needs a sign-off.

I haven't properly reviewed this yet.

Thanks,

Ben.