[ovs-dev] [PATCH] bitmap: Optimize bitmap_equal and bitmap_scan

[Kmindg G]

On Tue, Jul 29, 2014 at 1:01 AM, Ben Pfaff <blp at nicira.com> wrote:

> Needs a sign-off.
>

Oh..  I will not forget it in the next version.


>
> I'm pretty sure that bitmap_equal() is wrong: doesn't it access one
> past the end of the bitmap arrays?


You are right. I'll fix it.


> I think that rightmost_1bit_idx() might make bitmap_scan() faster.
>

I'll give it a try.


> The nice thing about the previous implementations was that they were
> obviously correct.  Now, I'd prefer to have some tests.
>
> No problem, I'll add some tests in the next version.

Thanks for reviewing