[ovs-dev] [PATCH 2/2] connmgr: Make call to connmgr_wants_packet_in_on_miss() thread safe.

Alex Wang alexw at nicira.com
Tue Jul 29 21:46:45 UTC 2014


Thx, pushed both patches to master and branch-2.3.

I'll try improving the thread-safety of connmgr module later,


On Tue, Jul 29, 2014 at 2:32 PM, Alex Wang <alexw at nicira.com> wrote:

>
>
>
> On Tue, Jul 29, 2014 at 2:16 PM, Andy Zhou <azhou at nicira.com> wrote:
>
>> On Tue, Jul 29, 2014 at 2:09 PM, Alex Wang <alexw at nicira.com> wrote:
>> > Thx for the suggestion, I think it will make the connmgr module safer
>> > if we annotate the ofproto->connmgr.  With a quick look, I think it will
>> > take more checking and efforts, (for functions we know that are only
>> called
>> > by the main thread, there is no lock protection)
>> Is this safe if ofproto->connmgr can be accessed by other threads?
>>
>
>
> I think it is safe.  since main thread creates/deletes the connmgr,
>
>
>
>
>> >
>> > For branch-2.3, I want to use this fix.  Do you think it is okay?
>> I suppose so, as long as the fix is safe. Your call.
>>
>
>
> Thx, will backport it soon,
>
>



More information about the dev mailing list