[ovs-dev] [PATCH] Change ovsext.inf Extension Name and GUID

[Saurabh Shah]

Hi Alin,

>Updates to the ovsext.inf to change the kernel extension name.
>
>This is in report to issue filed under:
>https://urldefense.proofpoint.com/v1/url?u=https://github.com/openvswitch/
>ovs/issues/14&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytvHEWufeZPpgqS
>OJMdMjuZPbesVsNhCUc0E%3D%0A&m=S0skvYEXPWVOPeQSEcDcFmROoadXLCcAs9GHHy4UEg8%
>3D%0A&s=37c5f4c4d5a856129e40eca233b5464221712d279b27f642b78ff3e50b8e3977
>by Saurabh Shah <ssaurabh at vmware.com>.
>
>Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
>Reported-by: Saurabh Shah <ssaurabh at vmware.com>
>---
> datapath-windows/ovsext/OvsDriver.c | 10 +++++-----
> datapath-windows/ovsext/ovsext.inf  | 24 ++++++++++++------------
> 2 files changed, 17 insertions(+), 17 deletions(-)
>
>diff --git a/datapath-windows/ovsext/OvsDriver.c
>b/datapath-windows/ovsext/OvsDriver.c
>index f027410..be6feeb 100644
>--- a/datapath-windows/ovsext/OvsDriver.c
>+++ b/datapath-windows/ovsext/OvsDriver.c
>@@ -51,12 +51,12 @@ static PWCHAR ovsExtServiceName = L"OVSExt";
> NDIS_STRING ovsExtGuidUC;
> NDIS_STRING ovsExtFriendlyNameUC;
> 
>-static PWCHAR ovsExtGuidStr = L"{583CC151-73EC-4A6A-8B47-578297AD7623}";
>+static PWCHAR ovsExtGuidStr = L"{8DD9C187-772D-452E-AC80-D29F9247BB7D}";
> static const GUID ovsExtGuid = {
>-      0x583cc151,
>-      0x73ec,
>-      0x4a6a,
>-      {0x8b, 0x47, 0x57, 0x82, 0x97, 0xad, 0x76, 0x23}
>+      0x8DD9C187,
>+      0x772D,
>+      0x452E,
>+      {0xAC, 0x80, 0xD2, 0x9F, 0x92, 0x47, 0xBB, 0x7D}
> };

Is there a reason to regenerate the GUID?

> 
> /* Declarations of callback functions for the filter driver. */
>diff --git a/datapath-windows/ovsext/ovsext.inf
>b/datapath-windows/ovsext/ovsext.inf
>index d1f68eb..f72f58c 100644
>--- a/datapath-windows/ovsext/ovsext.inf
>+++ b/datapath-windows/ovsext/ovsext.inf
>@@ -6,21 +6,21 @@
> Signature   = "$Windows NT$"
> Class       = NetService
> ClassGUID   = {4D36E974-E325-11CE-BFC1-08002BE10318}
>-Provider    = %VMWare%
>+Provider    = %OpenVSwitch%
> CatalogFile = ovsext.cat
> DriverVer   = 10/10/2013,1.0
> 
> [Manufacturer]
>-%VMWare%=VMWare,NTx86,NTia64,NTamd64
>+%OpenVSwitch%=OpenVSwitch,NTx86,NTia64,NTamd64
> 
>-[VMWare.NTx86]
>-%OVSExt_Desc%=Install, OVSExt
>+[OpenVSwitch.NTx86]
>+%OpenVSwitch%=Install, OVSExt
> 
>-[VMWare.NTia64]
>-%OVSExt_Desc%=Install, OVSExt
>+[OpenVSwitch.NTia64]
>+%OpenVSwitch%=Install, OVSExt
> 
>-[VMWare.NTamd64]
>-%OVSExt_Desc%=Install, OVSExt
>+[OpenVSwitch.NTamd64]
>+%OpenVSwitch%=Install, OVSExt
> 
> 
>;-------------------------------------------------------------------------
> ; Installation Section
>@@ -28,7 +28,7 @@ DriverVer   = 10/10/2013,1.0
> [Install]
> AddReg=Inst_Ndi
> Characteristics=0x40000
>-NetCfgInstanceId="{583CC151-73EC-4A6A-8B47-578297AD7623}"
>+NetCfgInstanceId="{8DD9C187-772D-452E-AC80-D29F9247BB7D}"
> Copyfiles = OVSExt.copyfiles.sys
> 
> [SourceDisksNames]
>@@ -80,6 +80,6 @@ AddReg          = Common.Params.reg
> DelService=OVSExt,0x200
> 
> [Strings]
>-VMWare = "VMWare"
>-OVSExt_Desc = "VMWare OVS Extension"
>-OVSExt_HelpText = "VMWare OVS forwarding switch extension"
>+OpenVSwitch = "OpenVSwitch"
>+OVSExt_Desc = "OpenVSwitch forwarding switch extension"
>+OVSExt_HelpText = "OpenVSwitch forwarding switch extension"
>-- 
>1.9.0.msysgit.0
>_______________________________________________
>dev mailing list
>dev at openvswitch.org
>https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/
>listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytvHEWufeZPpgqSO
>JMdMjuZPbesVsNhCUc0E%3D%0A&m=S0skvYEXPWVOPeQSEcDcFmROoadXLCcAs9GHHy4UEg8%3
>D%0A&s=03c9dc8fe80bb7d294dce86d13576e00e521737f4c92325e11b05f1a254a5111