[ovs-dev] Controller_status prototype build issue

[Taylor Johndrew]

Thank you. I have found another approach without including any new header files that compiled successfully. 

-----Original Message-----
From: Ben Pfaff [mailto:blp at nicira.com] 
Sent: Thursday, July 31, 2014 2:43 PM
To: Taylor Johndrew
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] Controller_status prototype build issue

On Tue, Jul 29, 2014 at 05:16:21PM +0000, Taylor Johndrew wrote:
> My name is Taylor Johndrew and I am working with Spike Curtis at 
> Metaswitch Networks to build a prototype of a new feature, the 
> controller_status message, to test for bugs in its specification.
> 
> I am trying to build ovs with my changes, but I have run into this error:
> 
> ./lib/ofp-msgs.h:422:16: error: invalid application of 'sizeof' to 
> incomplete type 'struct ofp_controller_status'
> 
> Also, I have found this warning that I believe is related:
> 
> lib/ofp-util.h:805:54: warning: 'struct ofp_controller_status'
> declared inside parameter list [enabled by default]
> lib/ofp-util.h:805:54: warning: its scope is only this definition or 
> declaration, which is probably not what you want [enabled by default]
> 
> 
> I believe the issue has to do with how I included the latest openflow 
> header file (see attached). I have renamed it openflow-1.5.h and 
> stored it under include/openflow/. In openflow.h I included the new 
> file, and I just recently updated the automake.mk to include the new
> 1.5 header.

This isn't the right approach at all.  Open vSwitch doesn't use anything like the ONF-released openflow.h.  You need to actually look at and understand the way the OpenFlow header files in Open vSwitch are structured instead of blindly copying in headers.