[ovs-dev] [PATCH] [PATCH] datapath-windows - fix crash when internal port is removed

[Saurabh Shah]

Hey Eitan,

>BSOD while setting AllowManagementOS on $false #13
>https://urldefense.proofpoint.com/v1/url?u=https://github.com/openvswitch/
>ovs/issues/13&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytvHEWufeZPpgqS
>OJMdMjuZPbesVsNhCUc0E%3D%0A&m=HCvhWNhGzijQI9QgNS1Zm2FCfEDPf3DswRG1vK1p1xA%
>3D%0A&s=3baeac3a021beacd5bca20512dd65dd5ec8ae5704a6e841fc8e49dd8854d962c
>
>Signed-off-by: Eitan Eliahu <eliahue at vmware.com>
>---
> datapath-windows/ovsext/OvsActions.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/datapath-windows/ovsext/OvsActions.c
>b/datapath-windows/ovsext/OvsActions.c
>index 79fb50f..62a98fa 100644
>--- a/datapath-windows/ovsext/OvsActions.c
>+++ b/datapath-windows/ovsext/OvsActions.c
>@@ -581,7 +581,12 @@ OvsTunnelPortTx(OvsForwardingContext *ovsFwdCtx)
>      * Setup the source port to be the internal port to as to facilitate
>the
>      * second OvsLookupFlow.
>      */
>-    ASSERT(ovsFwdCtx->switchContext->internalVport);
>+    if (ovsFwdCtx->switchContext->internalVport == NULL) {
>+        ASSERT(ovsFwdCtx->switchContext->internalVport);

This can¹t work because you are still asserting in the if() case. Perhaps
you forgot to remove the assert?

>+        OvsCompleteNBLForwardingCtx(ovsFwdCtx,
>+                                    L"OVS-Dropped - internal port
>removed");
>+        return NDIS_STATUS_FAILURE;
>+    }
>     ovsFwdCtx->srcVportNo =
>         
>((POVS_VPORT_ENTRY)ovsFwdCtx->switchContext->internalVport)->portNo;
> 
>-- 
>1.9.4.msysgit.0
>
>_______________________________________________
>dev mailing list
>dev at openvswitch.org
>https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/
>listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytvHEWufeZPpgqSO
>JMdMjuZPbesVsNhCUc0E%3D%0A&m=HCvhWNhGzijQI9QgNS1Zm2FCfEDPf3DswRG1vK1p1xA%3
>D%0A&s=07541f072b93faa9856ed01110b08324cb70c378a3d546fd5ea1e1d16ac13ac4