[ovs-dev] [PATCH] tests/ofproto-dpif.at: Add delay before stopping time.

Jarno Rajahalme jrajahalme at nicira.com
Thu Jun 5 16:51:19 UTC 2014


Pushed, with the sleep location back to what it was :-)

  Jarno

On Jun 4, 2014, at 2:02 PM, Andy Zhou <azhou at nicira.com> wrote:

> On Wed, Jun 4, 2014 at 12:00 PM, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
>> Add 2 second sleep before time stop to allow internal ports to
>> reconnect in case the initial connection attempt failed.
>> 
>> Bond tests sometimes persistently fail without these delays.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> Adding delay is not ideal, but it fixes a problem at hand. so
> 
> Acked-by: Andy Zhou <azhou at nicira.com>
> 
> I will come up with patch that allows ovs-appctl to pull for the
> connection status to replace
> those sleeps.
> 
>> +sleep 2
>> AT_CHECK([ovs-appctl netdev-dummy/set-admin-state up], 0, [OK
>> ])
>> AT_CHECK([ovs-ofctl add-flow br0 action=normal])
>> AT_CHECK([ovs-ofctl add-flow br1 action=normal])
>> AT_CHECK([ovs-appctl upcall/disable-megaflows], [0], [megaflows disabled
>> ], [])
>> -sleep 1;
> Why do we move the location of sleep?
>> ovs-appctl time/stop
>> ovs-appctl time/warp 100
>> ovs-appctl lacp/show > lacp.txt
>> --
>> 1.7.10.4
>> 
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> http://openvswitch.org/mailman/listinfo/dev




More information about the dev mailing list