[ovs-dev] [valgrind 5/5] poll-loop: Ignore 'wevent' in poll_fd_wait_at() on non-Windows.

Ben Pfaff blp at nicira.com
Thu Jun 5 18:38:59 UTC 2014


On Thu, Jun 05, 2014 at 07:35:43AM -0700, Gurucharan Shetty wrote:
> On Wed, Jun 4, 2014 at 5:07 PM, Ben Pfaff <blp at nicira.com> wrote:
> > 'wevent' isn't actually used on non-Windows systems, but poll_fd_wait_at()
> > and find_poll_node() treat events with different 'wevent' as different, so
> > it seems better to make sure that 'wevent' doesn't matter.
> >
> > Alternatively, one could ovs_assert(!wevent).  I guess that would catch
> > a caller accidentally swapping the 'fd' and 'wevent' arguments.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> Acked-by: Gurucharan Shetty <gshetty at nicira.com>

Thanks for the reviews.  I'll apply this series to master in a minute,
and then backport as necessary.



More information about the dev mailing list