[ovs-dev] [PATCH 1/3] ofproto: Honour NXFMF_OWN flag of flow monitors

Simon Horman horms at verge.net.au
Fri Jun 6 10:54:16 UTC 2014


If NXFMF_OWN is not set then full updates should be sent.
Prior to this change an abbreviated update is always sent
to the controller to which a monitor belongs, that is,
the NXFMF_OWN flag is ignored.

I noticed this while working on support for OpenFlow1.4 flow monitors.

Signed-off-by: Simon Horman <horms at verge.net.au>
---
 ofproto/connmgr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ofproto/connmgr.c b/ofproto/connmgr.c
index e0a097f..4eaede4 100644
--- a/ofproto/connmgr.c
+++ b/ofproto/connmgr.c
@@ -2201,7 +2201,8 @@ ofmonitor_report(struct connmgr *mgr, struct rule *rule,
                 ofconn->sent_abbrev_update = false;
             }
 
-            if (ofconn != abbrev_ofconn || ofconn->monitor_paused) {
+            if (!(flags & NXFMF_OWN) || ofconn != abbrev_ofconn
+                || ofconn->monitor_paused) {
                 struct ofputil_flow_update fu;
                 struct match match;
 
-- 
2.0.0.rc2




More information about the dev mailing list