[ovs-dev] [PATCH 1/3] netdev-dummy: add appctl netdev-dummy/conn-state command

Jarno Rajahalme jrajahalme at nicira.com
Sun Jun 8 20:32:08 UTC 2014



Sent from my iPhone

On Jun 8, 2014, at 12:32 AM, Andy Zhou <azhou at nicira.com> wrote:

>> What needs locking here? Could the locking be moved closer into the new function?
> 
> 
> The conn member is declared with OVS_GUARDED in netdev_dummy.  This is
> to make sure
> the mutex is held before accessing conn.  Am I still missing something here?

No, this is good, it's just me doing a review without looking at the source :-)

  Jarno




More information about the dev mailing list