[ovs-dev] [PATCH 5/7] netdev-vport: Truncate long names for tunnel backing ports.

Jesse Gross jesse at nicira.com
Wed Jun 11 18:11:32 UTC 2014


On Wed, Jun 11, 2014 at 3:04 AM, Thomas Graf <tgraf at suug.ch> wrote:
> On 06/10/14 at 04:47pm, Jesse Gross wrote:
>> In some cases, the names of tunnel protocols are longer than the
>> maximum allowed after concatenating port numbers. This truncates
>> names to the correct size rather than assert-failing on the assumption
>> that collisions between names of protocols are rather rate.
>>
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
>> ---
>>  lib/netdev-vport.c | 10 ++++------
>>  1 file changed, 4 insertions(+), 6 deletions(-)
>>
>> diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
>> index c214bf7..4dca091 100644
>> --- a/lib/netdev-vport.c
>> +++ b/lib/netdev-vport.c
>> @@ -151,14 +151,12 @@ netdev_vport_get_dpif_port(const struct netdev *netdev,
>>          const char *type = netdev_get_type(netdev);
>>
>>          /*
>> -         * Note: IFNAMSIZ is 16 bytes long. The maximum length of a VXLAN
>> -         * or LISP port name below is 15 or 14 bytes respectively. Still,
>> -         * assert here on the size of strlen(type) in case that changes
>> -         * in the future.
>> +         * Note: IFNAMSIZ is 16 bytes long. If the length of the type plus
>> +         * the rest of the name is greater than this, trucate the type to
>                                                          '''''''

Sorry, is there something you're trying to point out here?



More information about the dev mailing list