[ovs-dev] [PATCH v2] connmgr: Do not use OFPRR_METER_DELETE before OF1.4

Ben Pfaff blp at nicira.com
Thu Jun 12 18:32:07 UTC 2014


On Thu, Jun 12, 2014 at 02:30:47PM +0900, Simon Horman wrote:
> OFPRR_METER_DELETE was introduced in OF1.4 however meters were introduced
> in OF1.3.
> 
> Regardless of the OF version when flows are deleted cause flows to be
> deleted handle_delete_meter() calls delete_flows__() with
> OFPRR_METER_DELETE as the reason.
> 
> In order to avoid sending OFPRR_METER_DELETE to controllers connected
> using OF1.3 map OFPRR_METER_DELETE to OFPRR_DELETE which exists in that
> version.
> 
> Signed-off-by: Simon Horman <horms at verge.net.au>
> 
> ---
> v2
> * As suggested by Ben Pfaff
>   - Handle reason translation in ofputil_encode_flow_removed rather than
>     connmgr_send_flow_removed

Applied, thanks.

I guess we might generalize this to OFPRR_* and protocol versions.



More information about the dev mailing list