[ovs-dev] [PATCH 14/16] ofproto: Make hole in struct rule_actions by not caching provider_meter_id.

Ben Pfaff blp at nicira.com
Thu Jun 12 21:46:08 UTC 2014


On Tue, Jun 10, 2014 at 12:14:01AM +0100, Thomas Graf wrote:
> On 06/05/14 at 10:02pm, Ben Pfaff wrote:
> > Nothing actually used it.
> > 
> > An upcoming commit will use part of the hole for a new member.
> > 
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> LGTM in general
> 
> The commit description is slightly misleading as 'hole' suggests that
> none of struct rule_action's member offsets change which is not true.

The description wasn't very good.

I changed it to:

    ofproto: Shrink struct rule_actions slightly.        

    Nothing actually used 'provider_meter_id', but some code did want to know
    whether there was a meter, so we can save a little space by using a bool
    instead.  An upcoming commit will add a second bool member.  This change
    allows that bool to be added without using extra space.

Thanks,

Ben.



More information about the dev mailing list