[ovs-dev] [PATCH] netdev-vport: Use dpif_port as base for tunnel backing port.

Ben Pfaff blp at nicira.com
Fri Jun 13 23:13:15 UTC 2014


On Fri, Jun 13, 2014 at 12:08:40PM -0700, Jesse Gross wrote:
> In most cases, tunnel ports specify a dpif name to act as the backing
> port in the datapath. However, in the case of UDP tunnels the type is
> used with the port number appended. This is potentially a problem for
> IPsec tunnels because they have different types but should have the
> same backing port. The hasn't been a problem in practice though because
> no UDP tunnels are currently used with IPsec.
> 
> This switches to use the dpif_port in all cases plus a port number if
> necessary. It does this by making the names short enough to accomodate
> ports, which also makes the naming more consistent.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

...

> +         * Note: IFNAMSIZ is 16 bytes long. Implementations should chose

"choose"

> +         * a dpif port name that is short enough to fit including any
> +         * port numbers but assert just in case.
>           */

> +    /* The name of the dpif_port should be short enough to accomodate adding
> +     * port number to the end if one is necessary. */

"accommodate" adding "a" port number

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list