[ovs-dev] [MASTER 3/3] bridge: Make ovs-vswitchd run again if status_txn commit fails.

Alex Wang alexw at nicira.com
Sat Jun 14 00:50:44 UTC 2014


Applied all three patches to master, thx for the review,


On Fri, Jun 13, 2014 at 5:41 PM, Alex Wang <alexw at nicira.com> wrote:

> TXN_UNCOMMITTED should not be possible here (because we just committed
>> it).  If you want to check for it (I probably wouldn't bother) then
>> I'd use an assertion:
>> > +            /* Sets the 'status_txn_try_again' if the transaction
>> fails. */
>> > +            if (status == TXN_SUCCESS || status == TXN_UNCOMMITTED) {
>> > +                status_txn_try_again = false;
>> > +            } else {
>> > +                status_txn_try_again = true;
>> > +            }
>>
>
>
>
> Thanks for catching this!  It should be TXN_UNCHANGED.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140613/89c45633/attachment-0005.html>


More information about the dev mailing list