[ovs-dev] [PATCH] revalidator: Selectively perform xlate side-effects.

Alex Wang alexw at nicira.com
Mon Jun 23 17:26:24 UTC 2014


Hey Joe,

Sorry for the delayed reply,

Please see my comments inline,

On Sun, Jun 22, 2014 at 11:29 PM, Joe Stringer <joestringer at nicira.com>
wrote:

> Alex, could you review this series?
>
> I think that the correct solution is to perform "retroactive
> side-effects", that is, perform side effects as though they had happened at
> the time that the flow was hit. Anything that may hide these effects (like
> mac table flush) would need to be taken into account.
>


Totally agree,




>  However, such information is unavailable, and would be non-trivial to
> collect and maintain.
>


Totally agree,

So, I'm thinking this solution,

- in revalidate_ukey(), if need_revalidate is set, we always:
1. save the current xcache to old_xcache pointers.
2. conduct full revalidation (but never push stats during revalidation) and
    get a new xcache.
3.1. if the ukey is the same, delete the new xcache and push
stats/side-effects.
3.2. if the ukey is different, only push stats to old_xcache.  delete the
       old_xcache, and save the pointer to new xcache.


- in push_dump_ops__(), could we just push stats (skip the side-effects)
after
  deleting the flow?  This may require us to never miss dump flow from dp.


What do you think?

Thanks,
Alex Wang,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140623/c3fdf4aa/attachment-0005.html>


More information about the dev mailing list