[ovs-dev] [PATCH v7 3/3] dpif-netdev: batch packet processing

Daniele Di Proietto ddiproietto at vmware.com
Mon Jun 23 18:29:10 UTC 2014


On Jun 23, 2014, at 10:36 AM, Pravin Shelar <pshelar at nicira.com> wrote:

> On Sun, Jun 22, 2014 at 5:30 PM, Daniele Di Proietto
> <ddiproietto at vmware.com> wrote:
>> This change in dpif-netdev allows faster packet processing for devices which
>> implement batching (netdev-dpdk currently).
>> 
>> Signed-off-by: Daniele Di Proietto <ddiproietto at vmware.com>
> You have defined struct miniflowkey more than once for dpif-netdev.
> Can you define dpif-netdev specific key once in that module? we don't
> need it to be FLOW_U32S long, since we know we never going to use some
> of flow struct members like flow->regs.
> 

This definitely seems a good idea, thanks!

I’ll do the suggested changes and repost.

Daniele

> Otherwise looks good.
> Acked-by: Pravin B Shelar <pshelar at nicira.com>




More information about the dev mailing list