[ovs-dev] [PATCH] netdev-dpdk: Count and delete every dropped packet

Daniele Di Proietto ddiproietto at vmware.com
Tue Jun 24 23:04:20 UTC 2014


Commit f4fd623c4c25 introduced a bug in netdev_dpdk_send(): if multiple
consecutive packets exceed MTU, only the first one is deleted and
counted.

This should fix the bug

Signed-off-by: Daniele Di Proietto <ddiproietto at vmware.com>
---
 lib/netdev-dpdk.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 3359517..09db6f3 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -733,13 +733,13 @@ netdev_dpdk_send(struct netdev *netdev, struct dpif_packet **pkts, int cnt,
                     dpdk_queue_pkts(dev, qid,
                                     (struct rte_mbuf **)&pkts[next_tx_idx],
                                     i-next_tx_idx);
+                }
 
-                    VLOG_WARN_RL(&rl, "Too big size %d max_packet_len %d",
-                                 (int)size , dev->max_packet_len);
+                VLOG_WARN_RL(&rl, "Too big size %d max_packet_len %d",
+                             (int)size , dev->max_packet_len);
 
-                    dpif_packet_delete(pkts[i]);
-                    dropped++;
-                }
+                dpif_packet_delete(pkts[i]);
+                dropped++;
                 next_tx_idx = i + 1;
             }
         }
-- 
2.0.0




More information about the dev mailing list