[ovs-dev] [PATCH v3 02/41] connmgr: Support OFPFMF14_ONLY_OWN

Simon Horman horms at verge.net.au
Wed Jun 25 08:21:18 UTC 2014


On Mon, Jun 23, 2014 at 03:16:59PM -0700, Ben Pfaff wrote:
> On Mon, Jun 16, 2014 at 11:29:22AM +0900, Simon Horman wrote:
> > If the ONLY_OWN flag of a flow monitor is set then ofmonitor_report should
> > skip sending updates to other controllers.
> > 
> > This is in preparation for supporting OpenFlow1.4 flow monitors.
> > 
> > Signed-off-by: Simon Horman <horms at verge.net.au>
> 
> I suggest renaming abbrev_ofconn and abbrev_xid at this point, because
> their semantics are now a little different.  Previously they
> were essentially an optimization (I never meant to guarantee that
> changes would be abbreviated, and there were multiple special cases in
> which they wouldn't be), but now abbrev_ofconn really has to be
> correct or the controller won't get the monitor notifications that it
> should.

Thanks, I understand.

> request_ofconn and request_xid seem like OK names, but I'm open to
> better ones.

I have gone with request_ofconn and request_xid.




More information about the dev mailing list