[ovs-dev] [PATCH V2 2/5] netdev-dpdk: Add function for getting the socket_id of netdev-dpdk.

Thomas Graf tgraf at noironetworks.com
Wed Jun 25 09:59:14 UTC 2014


On 06/24/14 at 06:40pm, Alex Wang wrote:
> Signed-off-by: Alex Wang <alexw at nicira.com>
> ---
> PATCH -> V2:
> - Rebase.

LGTM, minor nitpick below.

Acked-by: Thomas Graf <tgraf at noironetworks.com>

> diff --git a/lib/netdev-dpdk.h b/lib/netdev-dpdk.h
> index f443a21..da507ce 100644
> --- a/lib/netdev-dpdk.h
> +++ b/lib/netdev-dpdk.h
> @@ -20,13 +20,18 @@ struct dpif_packet;
>  #include <rte_launch.h>
>  #include <rte_malloc.h>
>  
> +struct netdev;

Just in case you are going to rebase again anyway: Moving this
up to the struct dpif_packet declaration would avoid the need to
declare it again for non-dpdk.



More information about the dev mailing list