[ovs-dev] [PATCH] netdev-dpdk / arbitrary port naming for vhost ports

[Ben Pfaff]

On Wed, Jun 25, 2014 at 10:48:41AM +0000, Tahhan, Maryam wrote:
> Thanks for the feedback, I will refactor and resubmit, just a
> question regarding the section that sets the MAC address for the
> logical vhost port, is the issue just the formatting you mention
> after the comment about it being wrong or was there an issue with
> setting the MAC to something like 00:00:00:00:00:xx or
> 00:00:00:00:xx:00 where xx is the port number we assign to that
> port.

Formatting.  The diff showed the original code to be:
    if(netdev->port_id)
    if(netdev->port_id < 0xff)
which is not acceptable style because it fails to indent the second
'if' and because it fails to enclose the second 'if' in {}.

I didn't even look at the other issue you brought up.  I assume that
later reviewers will.