[ovs-dev] [PATCH v4] dpif-netdev: Implement batched flow dumping.

Ryan Wilson wryan at nicira.com
Wed Jun 25 20:02:19 UTC 2014


>
>
> Thanks Ryan!
>
> I folded in this change to ensure that the caller could specify any
> 'max_flows' that it likes.  It doesn't make sense for the caller to
> have to be aware of the implementation's limitations:
>
>
I was debating between either using an assert or using the min of max_flows
and FLOW_DUMP_MAX_BATCH as well. In the end, I think you're right; the
caller should not be limited by the underlying implementation. Thanks for
fixing this!


I also folded in the following to minimize the size of the overall
> change (when ignoring whitespace changes):
>
>
Thanks for fixing this as well!

Ryan



More information about the dev mailing list