[ovs-dev] [PATCH] CodingStyle: Functions in .c files should usually not be marked "inline".

Ben Pfaff blp at nicira.com
Wed Jun 25 20:58:55 UTC 2014


Thanks, applied to master.

On Wed, Jun 25, 2014 at 01:52:32PM -0700, Alex Wang wrote:
> Acked-by: Alex Wang <alexw at nicira.com>
> 
> 
> On Wed, Jun 25, 2014 at 1:44 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > I thought this was in here already, but I guess not.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> >  CodingStyle |    5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/CodingStyle b/CodingStyle
> > index 0ba0366..628f21f 100644
> > --- a/CodingStyle
> > +++ b/CodingStyle
> > @@ -162,6 +162,11 @@ such a function (including the C standard library
> > function free())
> >  should omit a null-pointer check.  We find that this usually makes
> >  code easier to read.
> >
> > +Functions in .c files should not normally be marked "inline", because
> > +it does not usually help code generation and it does suppress
> > +compilers warnings about unused functions.  (Functions defined in .h
> > +usually should be marked inline.)
> > +
> >
> >  FUNCTION PROTOTYPES
> >
> > --
> > 1.7.10.4
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >



More information about the dev mailing list