[ovs-dev] [PATCH v2 4/5] netdev-dpdk: Remove inline from static function dpdk_queue_pkts().

Pravin Shelar pshelar at nicira.com
Fri Jun 27 20:58:31 UTC 2014


On Thu, Jun 26, 2014 at 6:16 PM, Ryan Wilson <wryan at nicira.com> wrote:
> Per style requirements, functions local to a module should not be
> inlined.
>
GCC generates better code with inline marked function. This is
important when the function is called from PMD thread which is more
performance sensitive.

> Signed-off-by: Ryan Wilson <wryan at nicira.com>
> ---
>  lib/netdev-dpdk.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index dfa7d77..0aee14e 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -621,7 +621,7 @@ netdev_dpdk_rxq_recv(struct netdev_rxq *rxq_, struct dpif_packet **packets,
>      return 0;
>  }
>
> -inline static void
> +static void
>  dpdk_queue_pkts(struct netdev_dpdk *dev, int qid,
>                 struct rte_mbuf **pkts, int cnt)
>  {
> --
> 1.7.9.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list