[ovs-dev] [PATCH v2 4/5] netdev-dpdk: Remove inline from static function dpdk_queue_pkts().

Ryan Wilson 76511 wryan at vmware.com
Fri Jun 27 21:14:41 UTC 2014


Sorry about this, I should've been more mindful of that. Please ignore
this patch.

Ryan

On 6/27/14 2:04 PM, "Ben Pfaff" <blp at nicira.com> wrote:

>On Fri, Jun 27, 2014 at 1:58 PM, Pravin Shelar <pshelar at nicira.com> wrote:
>> On Thu, Jun 26, 2014 at 6:16 PM, Ryan Wilson <wryan at nicira.com> wrote:
>>> Per style requirements, functions local to a module should not be
>>> inlined.
>>>
>> GCC generates better code with inline marked function. This is
>> important when the function is called from PMD thread which is more
>> performance sensitive.
>
>OK, I don't want to eliminate "inline" where it makes an actual
>difference.
>(CodingStyle is meant to be worded flexibly enough to allow for that.)
>
>Thanks,
>
>Ben.




More information about the dev mailing list