[ovs-dev] [PATCH 1/5] openflow-1.4.h: Add bundle structure definitions

Ben Pfaff blp at nicira.com
Mon Mar 3 21:52:27 UTC 2014


On Mon, Mar 03, 2014 at 11:51:48PM +0200, Alexandru Copot wrote:
> On Mon, Mar 3, 2014 at 11:00 PM, Ben Pfaff <blp at nicira.com> wrote:
> > The above data structure isn't needed; OVS already handles experimenter
> > error codes through infrastructure in ofp-error.h.  You can update that
> > file with any new error types or codes.
> >
> > The various generic "property" definitions here have the same form as
> > those already used various places in OpenFlow and in particular in the
> > "table features" definitions in OpenFlow 1.3.  I'd prefer to handle them
> > generically rather than building up new infrastructure for each instance
> > of such properties in OpenFlow.  I'm working on that for "table
> > features" but I've been pretty slow about it.  Maybe I can catch up
> > soon.
> 
> Well, these experimenter codes and generic property definitions are not
> used for the moment by this feature. Maybe I should just remove them
> from here for the time being.

I think that's a good place to start.

> And I agree that it would be best to treat them in a generic way.

I'll try to catch up on that project.



More information about the dev mailing list