[ovs-dev] [PATCH] stp: Fix bpdu tx problem in listening state

Kmindg G kmindg at gmail.com
Mon Mar 17 02:17:23 UTC 2014


On Sun, Mar 16, 2014 at 12:50 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Wed, Mar 12, 2014 at 03:31:26PM +0800, Kmindg G wrote:
>> On Wed, Mar 12, 2014 at 1:41 PM, Ben Pfaff <blp at nicira.com> wrote:
>> > On Sun, Mar 09, 2014 at 05:48:52PM +0800, kmindg wrote:
>> >> The restriction only allows to send bpdu in forwarding state in
>> >> compose_output_action__. But a port could send bpdu in listening
>> >> and learning state according to comments in lib/stp.h(State of
>> >> an STP port).
>> >>
>> >> Signed-off-by: kmindg <kmindg at gmail.com>
>> >
>> > This appears to fix a bug, but I'm not sure exactly how bad that bug is,
>> > or what the symptoms of it are.  Does this patch mean that currently OVS
>> > isn't sending out BPDUs in certain STP states?  (In other words, that
>> > STP is currently broken?)
>>
>> Yes, currently OVS isn't sending out BPDUs in listening and learning states.
>> But those two states are temporary, the stp port will be in forwarding state
>> and send out BPDUs eventually (In the default configuration listening and
>> learning states last 15+15 second).
>>
>> So this minor problem may only increase the convergence time, in my opinion.
>
> Thanks for the extra explanation.  I added that to the commit message
> and applied this to master, branch-2.1, and branch-2.0.

Thanks for applying.   :)



More information about the dev mailing list