[ovs-dev] [PATCH 2/5] ofproto: Allow the use of the OpenFlow 1.4 protocol

[Alexandru Copot]

On Mon, Mar 17, 2014 at 7:08 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Mar 03, 2014 at 03:22:32PM +0200, Alexandru Copot wrote:
>> This defines the version number for OpenFlow 1.4 so that the switch
>> can actually use it. The ovsdb schema is also modified.
>>
>> Signed-off-by: Alexandru Copot <alex.mihai.c at gmail.com>
>> Cc: Daniel Baluta <dbaluta at ixiacom.com>
>
> I'm pretty happy with this.
>
> The one bit that I'm concerned about is that it allows OpenFlow 1.4 to
> be enabled even though there are unimplemented messages that will cause
> Open vSwitch to abort if ovs-vswitchd receives one.

This was my concern too after seeing that commit where you defined
the protocol versions as macros.

> We need to avoid that somehow; one way would be to not allow
> OpenFlow 1.4 to be enabled as long as any of those messages exist.

Do you mean to disable it until all those messages are implemented ?
It will be a while to implement all of OF 1.4. Maybe if we make it a build
configuration option, but not sure how to do that.