[ovs-dev] [PATCH V2] datapath: compat: Downstream the reciprocal_div.{c, h}.

Alex Wang alexw at nicira.com
Tue Mar 18 00:09:14 UTC 2014


Applied, thx~


On Mon, Mar 17, 2014 at 5:03 PM, Alex Wang <alexw at nicira.com> wrote:

> Thanks a lot for the review, ;D
>
>
>> > +#endif /* _LINUX_RECIPROCAL_DIV_WRAPPER_H */
>> > diff --git a/datapath/linux/compat/reciprocal_div.c
>> b/datapath/linux/compat/reciprocal_div.c
>> > index 7ec7528..8027214 100644
>> > --- a/datapath/linux/compat/reciprocal_div.c
>> > +++ b/datapath/linux/compat/reciprocal_div.c
>> > @@ -1,13 +1,26 @@
>> > +#include <linux/kernel.h>
>> >  #include <asm/div64.h>
>> >  #include <linux/reciprocal_div.h>
>> > +#include <linux/export.h>
>> >
>> Do we still need to include kernel.h and export.h?
>
>
>
> I think linux/kernel.h is needed for the min(), max().
>
>
> I'll remove the "#include <linux/export.h>" and apply,~!
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140317/9d84d464/attachment-0005.html>


More information about the dev mailing list