[ovs-dev] [PATCH 4/9] dpif-netdev: Add poll-mode-device thread.

Ben Pfaff blp at nicira.com
Wed Mar 19 22:29:39 UTC 2014


On Wed, Mar 19, 2014 at 03:16:37PM -0700, Pravin Shelar wrote:
> On Wed, Mar 19, 2014 at 11:08 AM, Ben Pfaff <blp at nicira.com> wrote:
> > On Tue, Mar 18, 2014 at 01:53:27PM -0700, Pravin wrote:
> > Polling the atomic variable only every 67,108,864 times through the
> > loop seems pretty conservative.  (Does that even poll once a second?)
> >
> I am not sure how to calculate one second in this loop efficiently.
> But I will try to use poll() rather than atomic variable here.

All I mean is that 64 million is a very large number and seems like it
might introduce a long delay, especially if packets are arriving
quickly.  If we reduce the number to, say, 1000, does it slow
operation down too much?

> > I think that the new 'md' member is the only real change in struct
> > dp_netdev_port.  A lot of members are reordered in that struct.  Is
> > that for organization, or speculation that it produces better cache
> > behavior, or...?
> >
> I just changed those member according to access pattern. I will keep
> struct as it is. we can improve it later.

OK.

Thanks,

Ben.



More information about the dev mailing list