[ovs-dev] [PATCH V5 2/5] dpif-netdev: Implement the API functions to allow multiple handler threads read upcall.

Alex Wang alexw at nicira.com
Thu Mar 20 17:40:44 UTC 2014


After discussion with Pravin, he thinks I can push my changes first.

So, applied the first to patches to master, thx,


On Wed, Mar 19, 2014 at 4:44 PM, Alex Wang <alexw at nicira.com> wrote:

> Thx Ben,
>
> I'll hold off the push and discuss with Pravin tmr,
>
>
> On Wed, Mar 19, 2014 at 4:32 PM, Ben Pfaff <blp at nicira.com> wrote:
>
>> On Wed, Mar 19, 2014 at 01:35:04PM -0700, Alex Wang wrote:
>> > This commit implements the API functions to allow multiple handler
>> > threads read upcall.
>> >
>> > Also, this commit removes the handling priority of DPIF_UC_MISS
>> > over DPIF_UC_ACTION.  So, both misses will be put to the same
>> > queue.  The decision is based on the fact that a lot has changed
>> > since the age when flow setup rate is most treasured and starving
>> > all actions in the presence of any flow misses doesn't seem like
>> > a sound balancing solution.
>> >
>> > Thusly the current implementation will be put in testing and
>> > investigation for better balancing solution will continue if
>> > there is an issue.
>> >
>> > Also note, the introduction and use of flow_hash_5tuple() will
>> > put missed ICMP packets from same source but with different
>> > type/code to different handler queues.  This may cause reordering
>> > of these packets.  For now, we do not count this as a problem.
>> >
>> > Signed-off-by: Alex Wang <alexw at nicira.com>
>>
>> Alex, Pravin is also changing dpif-netdev, to add DPDK support.
>> Please coordinate with him to figure out who should make changes first
>> and to make sure that your changes don't conflict with each other.
>>
>> Acked-by: Ben Pfaff <blp at nicira.com>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140320/cec9faa3/attachment-0005.html>


More information about the dev mailing list