[ovs-dev] [PATCH V5 3/5] datapath: Allow each vport to have an array of 'port_id's.

Alex Wang alexw at nicira.com
Thu Mar 20 20:07:01 UTC 2014


Jesse could you review this patch when you are available? Thx

Hope it is close,

On Wed, Mar 19, 2014 at 4:33 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Wed, Mar 19, 2014 at 04:33:17PM -0700, Ben Pfaff wrote:
> > On Wed, Mar 19, 2014 at 01:35:05PM -0700, Alex Wang wrote:
> > > In order to allow handlers directly read upcalls from datapath,
> > > we need to support per-handler netlink socket for each vport in
> > > datapath.  This commit makes this happen.  Also, it is guaranteed
> > > backward and forward compatibility with previous branch.
> > >
> > > Signed-off-by: Alex Wang <alexw at nicira.com>
> > > Acked-by: Thomas Graf <tgraf at redhat.com>
> >
> > Needs Jesse's review.
>
> Also, adds a sparse warning:
>
>     /home/blp/ovs/_build/datapath/linux/vport.c:167:20: warning: incorrect
> type in argument 1 (different address spaces)
>     /home/blp/ovs/_build/datapath/linux/vport.c:167:20:    expected void
> const *<noident>
>     /home/blp/ovs/_build/datapath/linux/vport.c:167:20:    got struct
> vport_portids [noderef] <asn:4>*upcall_portids
>


I could not see the warning on server and vm using sparse.

But I'll use a cast to convert the "struct vport_portids __rcu *" to
"struct vport_portids *"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140320/45e3d3db/attachment-0005.html>


More information about the dev mailing list