[ovs-dev] [PATCH V2 06/10] netdev: Add support multiqueue recv.

Thomas Graf tgraf at redhat.com
Fri Mar 21 22:09:44 UTC 2014


On 03/21/2014 07:03 PM, Pravin wrote:
> new netdev type like DPDK can support multi-queue IO. Following
> patch Adds support for same.
>
> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>

Straight forward patch

Acked-by: Thomas Graf <tgraf at redhat.com>

> @@ -514,15 +527,16 @@ netdev_parse_name(const char *netdev_name_, char **name, char **type)
>    * Some kinds of network devices might not support receiving packets.  This
>    * function returns EOPNOTSUPP in that case.*/
>   int
> -netdev_rxq_open(struct netdev *netdev, struct netdev_rxq **rxp)
> +netdev_rxq_open(struct netdev *netdev, struct netdev_rxq **rxp, int id)
>       OVS_EXCLUDED(netdev_mutex)
>   {
>       int error;
>
> -    if (netdev->netdev_class->rxq_alloc) {
> +    if (netdev->netdev_class->rxq_alloc && id < netdev->n_rxq) {

Could perhaps consider to assert on id >= netdev->n_rxq since
n_rxq should feed the loop opening the rxq.



More information about the dev mailing list