[ovs-dev] [RFC PATCH 3/4] lib/ofpbuf: Remove 'l7' pointer.

Ben Pfaff blp at nicira.com
Mon Mar 24 21:57:07 UTC 2014


On Mon, Mar 24, 2014 at 02:53:44PM -0700, Pravin Shelar wrote:
> On Mon, Mar 24, 2014 at 2:21 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Mon, Mar 24, 2014 at 10:59:05AM -0700, Jarno Rajahalme wrote:
> >> Now that we don't need to parse TCP flags from the packet after
> >> extraction, we usually do not need the 'l7' pointer any more.  When
> >> needed, ofpbuf_get_tcp|udp|sctp|icmp_payload() or ofpbuf_get_l4_size()
> >> can be used instead.
> >>
> >> Removal of 'l7' was requested by Pravin for the DPDK datapath work, as
> >> it simplifies packet parsing a bit.
> >
> > Pravin, I'm curious about how removing l7 simplifies the DPDK
> > datapath.  Can you tell us?
> 
> This improves flow_extract performance. Most of time l7 is not used
> therefore initializing it for every packet does not accomplish much.

I see, thanks.



More information about the dev mailing list