[ovs-dev] [bond megaflow v4 3/4] dpif-netdev: user space datapath recirculation

Ben Pfaff blp at nicira.com
Tue Mar 25 20:17:12 UTC 2014


On Tue, Mar 25, 2014 at 01:11:52PM -0700, Andy Zhou wrote:
> On Tue, Mar 25, 2014 at 9:04 AM, Ben Pfaff <blp at nicira.com> wrote:
> > On Mon, Mar 24, 2014 at 06:58:43PM -0700, Andy Zhou wrote:
> >> Add basic recirculation infrastructure and user space
> >> data path support for it. The following bond mega flow patch will
> >> make use of this infrastructure.
> >>
> >> Signed-off-by: Andy Zhou <azhou at nicira.com>
> >
> > I'm not sure the placement of the new enumeration values in enum
> > ovs_key_attr is correct.  In particular, I don't entirely understand why
> > OVS_KEY_ATTR_IPV4_TUNNEL is in #ifdef __KERNEL__, but if that value is
> > part of the ABI then the new values should go after it.
> >
> > I am not sure that putting pad bytes in the middle of ovs_action_recirc
> > is a great idea.  I might just make hash_alg a uint32.
> >
> 
> The following incremental change should fix the issues mentioned above.

Thanks.

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list