[ovs-dev] [PATCH 1/4] ovs-appctl: Close the connection gracefully during error.

Ben Pfaff blp at nicira.com
Fri Mar 28 16:53:14 UTC 2014


On Fri, Mar 28, 2014 at 09:10:43AM -0700, Gurucharan Shetty wrote:
> When we send a wrong command to a Open vSwitch daemon, it returns
> an error. In that case, we should gracefully close the connection
> to the daemon.
> 
> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>

At root, I don't think this does anything more graceful than just
exiting, because it looks to me like it just closes the socket without
doing anything fancy like flushing buffers, etc.

But cleaning up is nice in any case; it will at least make for better
reports from leak checkers, etc.  So:

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list