[ovs-dev] [PATCH] ovs-dpctl: Don't print mask when all fields exact-match.

Ben Pfaff blp at nicira.com
Thu May 1 15:00:21 UTC 2014


On Mon, Apr 28, 2014 at 10:25:21PM -0700, Arun Sharma wrote:
> For each field, if the mask is all zeros, don't print it at all,
> if it is all ones, print it without the mask trailer.
> If it is neither of those two, print the value and mask in the current
> form.
> 
> Removed inconsistency in format 0x% and %#, kept %# for mask as hex
> format.
> 
> Bug# 1191729
> 
> Reported-by: Justin Pettit <jpettit at nicira.com>
> Signed-off-by: Arun Sharma <arun.sharma at calsoftinc.com>

This patch has a lot of statements of the form:
        if ((a ^ b) != 0)
Please rewrite all of them as:
        if (a != b)



More information about the dev mailing list