[ovs-dev] [PATCH] datapath: handle recirculation loop detection

Andy Zhou azhou at nicira.com
Fri May 2 15:34:28 UTC 2014


On Fri, May 2, 2014 at 6:22 AM, Thomas F Herbert
<thomasfherbert at gmail.com> wrote:
> On 5/1/2014 4:21 PM, Jesse Gross wrote:
>>
>> On Wed, Apr 30, 2014 at 4:46 PM, Andy Zhou <azhou at nicira.com> wrote:
>>>
>>> diff --git a/datapath/actions.c b/datapath/actions.c
>>> index 5871d82..5556a0c 100644
>>> --- a/datapath/actions.c
>>> +++ b/datapath/actions.c
>>> @@ -644,22 +649,24 @@ static DEFINE_PER_CPU(struct loop_counter,
>>> loop_counters);
>>>   static int loop_suppress(struct datapath *dp, struct sw_flow_actions
>>> *actions)
>>>   {
>>>          if (net_ratelimit())
>>> -               pr_warn("%s: flow looped %d times, dropping\n",
>>> -                               ovs_dp_name(dp), MAX_LOOPS);
>>> +               pr_warn("%s: flow looped detected, dropping\n",
>
> Probably should be "flow loop detected,..." not "flow looped detected"
Thanks, I believe I fixed this before pushing to master. Would you
please double check?
>>>
>>> +                               ovs_dp_name(dp));
>>
>> I think the message should read "flow loop detected" i.e. present
>> tense but otherwise this looks good to me.
>>
>> Acked-by: Jesse Gross <jesse at nicira.com>
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> http://openvswitch.org/mailman/listinfo/dev
>
>



More information about the dev mailing list