[ovs-dev] [PATCH] netdev-vport: Checks tunnel status change when route-table is reset.

Alex Wang alexw at nicira.com
Fri May 2 17:30:02 UTC 2014


Thanks Ben for the review, my reply below,


>
> > Bug #1240626
> >
> > Signed-off-by: Alex Wang <alexw at nicira.com>
>
> The new version of tunnel_check_status_change__() uses memset(),
> memcpy(), and memcmp() to work with strings.  Is there some reason that
> one can't use the normal approach for strings, e.g. set byte 0 to '\0'
> to make it empty and strcmp() and ovs_strlcpy() to copy?
>


There is no particular reason.  I'll adjust.



> netdev_vport_route_changed() doesn't appear to use the names in the
> shash, so it might make more sense for netdev_get_vports() to just
> return an array of pointers to netdevs instead of wasting the extra time
> and space on an shash.
>


Okay, I can do that,



>
> There seems to be an assumption that netdev_run() and netdev_wait() are
> called single-threaded.  I think this might actually be true now, and
> the assumption was there before (more subtly), so it's probably not a
> big deal.
>

Yes, there is.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140502/6cd4f2d4/attachment-0005.html>


More information about the dev mailing list