[ovs-dev] [PATCH 3/3] netdev: Warn on opening netdev as unexpected type.

[Ryan Wilson]

Hey Joe,

This looks good to me and fixes the root cause which is even better. I'm fairly new to OVS, so my ack likely doesn't mean much :)

Ryan Wilson
Member of Technical Staff
wryan at vmware.com
3401 Hillview Avenue, Palo Alto, CA
650.427.1511 Office
916.588.7783 Mobile

On May 5, 2014, at 8:16 PM, Joe Stringer <joestringer at nicira.com> wrote:

> Thanks for taking a look Ryan. That sounds exactly like the issue I encountered. 
> 
> Looking at your assessment made me take a look at it again, and I found a much better solution. Do you mind taking a look at that one?
> 
> http://openvswitch.org/pipermail/dev/2014-May/039790.html
> 
> 
> On 6 May 2014 09:18, Ryan Wilson <wryan at vmware.com> wrote:
> I've seen this issue before as well when adding RCU locking to xlate. It happens because refs to a netdev still exist (in this case, likely the tunnel has a ref to the netdev) when the main thread tries to delete the netdev. Thus, the netdev never gets deleted and the netdev cannot be recreated with a new type. I tested out the fix and it works with my patch as well.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140506/1b69e565/attachment-0005.html>