[ovs-dev] [PATCH] ofproto-dpif-xlate: Implement RCU locking in ofproto-dpif-xlate.

Ben Pfaff blp at nicira.com
Fri May 9 15:29:26 UTC 2014


Is this still up-to-date?  I know that we've had a lot of discussion and
a couple of patch versions related to netdevs this week.

More below.

On Tue, May 06, 2014 at 09:54:12AM -0700, Ryan Wilson wrote:
> Before, a global read-write lock protected the ofproto-dpif / ofproto-dpif-xlate
> interface. Handler and revalidator threads had to wait while configuration was
> being changed. This patch implements RCU locking which allows handlers and
> revalidators to operate while configuration is being updated.
> 
> This patch also frees netdev with ovsrcu_postpone. This is because if RCU
> reader threads take a ref to the netdev, the netdev cannot be deleted and
> re-created with different types.

I have to say that I don't understand the previous paragraph of the
commit message.  Maybe you could spell it out more precisely?  Also, the
netdev portion of the commit seems to have little to do with the rest,
so I'd be inclined to make it a separate preparatory commit.



More information about the dev mailing list