[ovs-dev] [PATCH] dpif-netdev: Always serialise recirc_id to upcall key.

Andy Zhou azhou at nicira.com
Fri May 9 17:00:25 UTC 2014


I believe Joe is working on V2 to address a similar issue with
dp_hash.  I chatted with him last night.

The OF rule lookup in the user space will always generate exact match
for recirc id, Causing flow dump to always encode both key and mask
for recirc_id.


On Fri, May 9, 2014 at 8:14 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Fri, May 09, 2014 at 02:35:44PM +1200, Joe Stringer wrote:
>> This was causing a mismatch between the odp flow key in an upcall
>> compared to the odp flow key that is serialised upon flow_dump.
>>
>> Signed-off-by: Joe Stringer <joestringer at nicira.com>
>
> I agree that the flow keys that appear in the flow dump and in upcalls
> should match.  This change implies that flow dumps always include a
> recirc_id.  But why does that happen?  I don't see obvious code in
> dpif-netdev.c that does that.
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list