[ovs-dev] [of1.5 v2 07/20] ofp-util: Implement OpenFlow 1.4 port status and port desc reply messages.

Alexandru Copot alex.mihai.c at gmail.com
Sun May 11 18:39:32 UTC 2014


On Sat, May 10, 2014 at 5:40 AM, Ben Pfaff <blp at nicira.com> wrote:
> Signed-off-by: Ben Pfaff <blp at nicira.com>

>
> diff --git a/lib/ofp-msgs.h b/lib/ofp-msgs.h
> index df7569e..b548f6b 100644
> --- a/lib/ofp-msgs.h
> +++ b/lib/ofp-msgs.h
> @@ -162,8 +162,10 @@ enum ofpraw {
>
>      /* OFPT 1.0 (12): struct ofp_port_status, struct ofp10_phy_port. */
>      OFPRAW_OFPT10_PORT_STATUS,
> -    /* OFPT 1.1+ (12): struct ofp_port_status, struct ofp11_port. */
> +    /* OFPT 1.1-1.3 (12): struct ofp_port_status, struct ofp11_port. */
>      OFPRAW_OFPT11_PORT_STATUS,
> +    /* OFPT 1.4+ (12): struct ofp_port_status, struct ofp14_port, uint8_t[8][]. */
> +    OFPRAW_OFPT14_PORT_STATUS,
>
>      /* OFPT 1.0 (13): struct ofp10_packet_out, uint8_t[]. */
>      OFPRAW_OFPT10_PACKET_OUT,
> @@ -360,8 +362,10 @@ enum ofpraw {
>
>      /* OFPST 1.0 (13): struct ofp10_phy_port[]. */
>      OFPRAW_OFPST10_PORT_DESC_REPLY,
> -    /* OFPST 1.1+ (13): struct ofp11_port[]. */
> +    /* OFPST 1.1-1.3 (13): struct ofp11_port[]. */
>      OFPRAW_OFPST11_PORT_DESC_REPLY,
> +    /* OFPST 1.4+ (13): uint8_t[8][]. */
> +    OFPRAW_OFPST14_PORT_DESC_REPLY,
>
>  /* Nicira extension messages.
>   *
> @@ -471,7 +475,8 @@ enum ofptype {
>                                    * OFPRAW_OFPT11_FLOW_REMOVED.
>                                    * OFPRAW_NXT_FLOW_REMOVED. */
>      OFPTYPE_PORT_STATUS,         /* OFPRAW_OFPT10_PORT_STATUS.
> -                                  * OFPRAW_OFPT11_PORT_STATUS. */
> +                                  * OFPRAW_OFPT11_PORT_STATUS.
> +                                  * OFPRAW_OFPT14_PORT_STATUS. */
>

Now that there is OFPRAW_OFPT14_PORT_STATUS, encode_port_status()
should use it for OF1.4 instead of OFPRAW_OFPT11_PORT_STATUS. Otherwise,
now we get an abort.



More information about the dev mailing list