[ovs-dev] [PATCH] lib/classifier: Simpilify array ordering.

Ben Pfaff blp at nicira.com
Wed May 14 17:30:50 UTC 2014


On Mon, May 12, 2014 at 11:21:11PM -0700, Jarno Rajahalme wrote:
> The terminology we used for subtable ordering ('splice', 'right
> before') was inherited from an earlier use of a linked list, and
> turned out to be confusing when applied to an array.  Also, we only
> ever move one subtable earlier or later within the array, so we can
> simplify the code as well.
> 
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

Each of the callers has an explicit test for to != from.  Can we just
move that into cls_subtable_cache_move()?

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list