[ovs-dev] [of1.5 v2 00/20] Make OF1.4 safe and add some OF1.5 features

[Ben Pfaff]

I felt that the reviews of this series, while not too thorough, along with the
unit tests were good enough to ensure that there should be low risk for
users who aren't using OpenFlow 1.4 or 1.5, so I pushed the series.

Of course, further scrutiny and testing is welcome, as always.

On Fri, May 9, 2014 at 7:40 PM, Ben Pfaff <blp at nicira.com> wrote:
> v1->v2:
>   - Actually make OF1.4 completely safe to use and enable it without
>     needing a command-line override.  (This involved adding implementations
>     many more OF1.4 features than in v1.)
>   - Add EXT-109 implementation.
>   - Fix treatment of table-features error codes in OF1.5 (thanks to Jean
>     Tourrilhes for pointing out my mistake!).
>
> Ben Pfaff (20):
>   ovs-ofctl: Fix port lookup and "ovs-ofctl" behavior for OpenFlow 1.3+.
>   ofp-util: Fix definition of OFPUTIL_P_OF13_UP.
>   ofp-msgs: New functions ofpmp_version() and ofpmp_decode_raw().
>   ofp-util: Remove ofputil_count_phy_ports().
>   ofp-util: Generalize functions for parsing OF1.3+ properties.
>   ofp-util: Reduce duplicate code.
>   ofp-util: Implement OpenFlow 1.4 port status and port desc reply
>     messages.
>   Implement OpenFlow 1.4 port_mod messages.
>   Implement basic OpenFlow 1.4 table-mod message.
>   Implement OpenFlow 1.4 port statistics.
>   Implement OpenFlow 1.4 queue statistics.
>   ofp-util: Simplify ofputil_decode_switch_features().
>   ofp-util: Remove ofputil_get_phy_port_size().
>   Remove --enable-of14 option because the implementation is now safe.
>   Add skeleton for OF1.5 support.
>   Implement OpenFlow 1.5 group desc stats request.
>   Implement OpenFlow 1.5 port desc stats request.
>   nx-match: Refactor nxm_put_ip() to handle all IPv4 and IPv6 fields.
>   meta-flow: Encode OXM version information into the flow table.
>   meta-flow: Use OXM-defined constant for TCP flags in OpenFlow 1.5.
>
>  FAQ                                |  44 +-
>  build-aux/extract-ofp-errors       |   3 +-
>  build-aux/extract-ofp-msgs         |  52 ++-
>  include/openflow/openflow-1.2.h    |  15 +-
>  include/openflow/openflow-1.4.h    | 188 +++++++-
>  include/openflow/openflow-common.h |  11 +-
>  lib/meta-flow.c                    | 122 +++---
>  lib/meta-flow.h                    |  13 +-
>  lib/nx-match.c                     | 186 ++++----
>  lib/nx-match.h                     |   2 +-
>  lib/ofp-actions.c                  |   7 +-
>  lib/ofp-errors.c                   |   2 +
>  lib/ofp-errors.h                   |  46 +-
>  lib/ofp-msgs.c                     |  32 +-
>  lib/ofp-msgs.h                     |  63 ++-
>  lib/ofp-print.c                    |  67 ++-
>  lib/ofp-util.c                     | 858 +++++++++++++++++++++++++++----------
>  lib/ofp-util.h                     |  39 +-
>  ofproto/ofproto.c                  | 131 +++---
>  tests/learn.at                     |   8 +-
>  tests/ofp-errors.at                |   2 +
>  tests/ofp-print.at                 | 142 +++++-
>  tests/ofproto-macros.at            |   4 +-
>  tests/ofproto.at                   | 101 +++++
>  tests/ovs-ofctl.at                 | 246 ++++++-----
>  utilities/ovs-ofctl.8.in           |  44 +-
>  utilities/ovs-ofctl.c              | 147 ++++---
>  vswitchd/bridge.c                  |  23 +-
>  vswitchd/bridge.h                  |   2 -
>  vswitchd/ovs-vswitchd.8.in         |  10 -
>  vswitchd/ovs-vswitchd.c            |   7 -
>  vswitchd/vswitch.ovsschema         |   7 +-
>  vswitchd/vswitch.xml               |  18 +-
>  33 files changed, 1853 insertions(+), 789 deletions(-)
>
> --
> 1.9.1
>



-- 
"I don't normally do acked-by's.  I think it's my way of avoiding
getting blamed when it all blows up."               Andrew Morton