[ovs-dev] [PATCH] netdev: Remove netdev from global shash when the user is changing interface configuration.

[Alex Wang]

Hey Ryan,

Glad to see this workaround,

To my understanding, we only remove/free netdev when the iface is removed
by main thread.  So, I think this would work.

I'll wait for Ben's review.


 void netdev_parse_name(const char *netdev_name, char **name, char **type);
> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index 43c109c..7189340 100644
> --- a/vswitchd/bridge.c
> +++ b/vswitchd/bridge.c
> @@ -3471,7 +3471,7 @@ iface_destroy__(struct iface *iface)
>          list_remove(&iface->port_elem);
>          hmap_remove(&br->iface_by_name, &iface->name_node);
>
> -        netdev_close(iface->netdev);
> +        netdev_remove(iface->netdev);
>
>

Maybe a reminder comment here about why we need to call netdev_remove().




>          free(iface->name);
>          free(iface);
> --
> 1.7.9.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140515/a77e1eb7/attachment-0005.html>